Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm query params #465

Merged
merged 1 commit into from
Dec 1, 2020
Merged

evm query params #465

merged 1 commit into from
Dec 1, 2020

Conversation

ilovers
Copy link
Contributor

@ilovers ilovers commented Dec 1, 2020

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@zhongqiuwood zhongqiuwood merged commit ec04c81 into dev Dec 1, 2020
@zhongqiuwood zhongqiuwood deleted the dev-evm-query-params branch December 1, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongqiuwood zhongqiuwood zhongqiuwood approved these changes

@xiangjianmeng xiangjianmeng xiangjianmeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilovers @xiangjianmeng @zhongqiuwood