Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php 8 support #13

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Add php 8 support #13

merged 2 commits into from
Dec 7, 2021

Conversation

yoanmLf
Copy link
Collaborator

@yoanmLf yoanmLf commented Aug 6, 2021

No description provided.

@yoanmLf
Copy link
Collaborator Author

yoanmLf commented Aug 6, 2021

Do you prefer to totally drop php 7 support ?
Will save 2 travis containers in that case 🤔

@yoanmLf yoanmLf marked this pull request as ready for review August 16, 2021 14:29
@yoanmLf
Copy link
Collaborator Author

yoanmLf commented Oct 8, 2021 •
edited
Loading

Ping @olaurendeau (it's required to move projects to PHP 8, cooldown is starting :) )

@yoanmLf
Copy link
Collaborator Author

yoanmLf commented Dec 7, 2021

N.B. Travis doesn't seem to be triggered :|

@olaurendeau olaurendeau merged commit d37439e into olaurendeau:master Dec 7, 2021
@yoanmLf
Copy link
Collaborator Author

yoanmLf commented Jan 11, 2022 •
edited
Loading

FYI @olaurendeau, see richardfullmer/php-rabbitmq-management-api#14 and richardfullmer/php-rabbitmq-management-api#11.
Without travis it's hard to detect that :/ Basically, this project is PHP 8 ready, but the underlying lib is not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoanmLf @olaurendeau