Fix crash on windows (error code: 1410) when tray icon created again #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! This is now released under version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to create tray icon again in a GUI application. However, the process crashes when tray icon created at the second time.
Because,
See https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-registerclassw#remarks
When the application creates tray icon again, calling to
RegisterClassWwill return error.Maybe, we can ignore errors from calling
RegisterClassWjust like tauri-apps/tray-icon does.See https://github.com/tauri-apps/tray-icon/blob/302f29e48c2dc4cec1adc9ef67a80d93c0c90b16/src/platform_impl/windows/mod.rs#L89