QA-820 os licenses split - the frontend part #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldgiova
reviewed
Nov 28, 2024
frontend/pipeline.yml
Outdated
| paths: | ||
| - licenses.md | ||
|
|
||
| publish:frontend:licenses:docs-site: |
There was a problem hiding this comment.
Maybe is it better to move this to the main .gitlab-ci.yml and use a single publish:license:docs-site for both backend and frontend?
Like (here)[https://github.com/mendersoftware/pull/220/files#diff-037ea159eb0a7cb0ac23b851e66bee30fb838ee8d0d99fa331a1ba65283d37f7R431] setting the two jobs:
needs:
- job: publish:backend:licenses
artifacts: true
- job: publish:frontend:licenses
artifacts: true
And get an unified LICENSE.md file, also for a single mender-docs page?
There was a problem hiding this comment.
sure we can do that as well - I just carried on with the split until then, but I'll adjust 👌
Ticket: QA-820 Changelog: None Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
mzedel
force-pushed
the
QA-820-os-licenses-split
branch
from
3bf5a3f to
6c84dc5
Compare
oldgiova
pushed a commit
that referenced
this pull request
Dec 3, 2024
chore: add depenabot configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-licenses format is not 100% matched, as I don't get the location of the license file from the license collection tool I get the
licenses.jsonfrom - so this just links to the repository... I hope that's tolerable @oldgiova