Merge pull request #50 from liuyangc3/master

增加对非root用户启动的JVM的支持
oldratlee · Nov 14, 2015 · 7ddc8bc · 7ddc8bc
2 parents 1cb12d2 + 93305e2
commit 7ddc8bc
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -21,6 +21,7 @@ source <(curl -fsSL https://raw.githubusercontent.com/oldratlee/useful-scripts/m
 
 1. [show-busy-java-threads.sh](docs/java.md#beer-show-busy-java-threadssh)  
     打印出在运行的`Java`进程中，消耗`CPU`最多的线程栈。用于快速排查`Java`的性能问题。
+    如果执行脚本的用户不是root,需要前面加上sudo
 1. [show-duplicate-java-classes](docs/java.md#beer-show-duplicate-java-classes)  
     找出`jar`文件和`class`目录中的重复类。用于排查`Java`类冲突问题。
 1. [find-in-jars.sh](docs/java.md#beer-find-in-jarssh)  

diff --git a/show-busy-java-threads.sh b/show-busy-java-threads.sh
@@ -83,30 +83,36 @@ cleanupWhenExit() {
 trap "cleanupWhenExit" EXIT
 
 printStackOfThread() {
-    local threadLine
+    local line
     local count=1
-    while read threadLine ; do
-        local pid=`echo ${threadLine} | awk '{print $1}'`
-        local threadId=`echo ${threadLine} | awk '{print $2}'`
+    while IFS=" " read -a line ; do
+        local pid=${line[0]}
+        local threadId=${line[1]}
         local threadId0x=`printf %x ${threadId}`
-        local user=`echo ${threadLine} | awk '{print $3}'`
-        local pcpu=`echo ${threadLine} | awk '{print $5}'`
+        local user=${line[2]}
+        local pcpu=${line[4]}
 
         local jstackFile=/tmp/${uuid}_${pid}
 
         [ ! -f "${jstackFile}" ] && {
-            jstack ${pid} > ${jstackFile} || {
+            {
+                if [ "${user}" == "${USER}" ];then
+                    jstack ${pid} > ${jstackFile}
+                else
+                    sudo -u ${user} jstack ${pid} > ${jstackFile}
+                fi
+            } || {
                 redEcho "Fail to jstack java process ${pid}!"
                 rm ${jstackFile}
                 continue
             }
         }
-
         redEcho "[$((count++))] Busy(${pcpu}%) thread(${threadId}/0x${threadId0x}) stack of java process(${pid}) under user(${user}):"
         sed "/nid=0x${threadId0x} /,/^$/p" -n ${jstackFile}
     done
 }
 
+
 ps -Leo pid,lwp,user,comm,pcpu --no-headers | {
     [ -z "${pid}" ] &&
     awk '$4=="java"{print $0}' ||