Sign assemblies #7
Open
+8
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change creates strong-named versions of the assemblies. While this doesn't have any benefits in regards to security it helps those projects that (for whatever reason) are required to create strong-named assemblies because all dependencies have to be strong-named as well. Since signing an assembly doesn't help in any ways in regards to security, it doesn't hurt if we add the key file to the repo.
This change adds the version and file version to the assemblies. It also fixes the nuget package version for Sandwych.QuickGraph.Core.
|
Thanks for your contribution, I'll find some spare time to fix the CI problem(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates strong-named versions of the assemblies. While this
doesn't have any benefits in regards to security it helps those projects
that (for whatever reason) are required to create strong-named assemblies
because all dependencies have to be strong-named as well.
Since signing an assembly doesn't help in any ways in regards to security,
it doesn't hurt if we add the key file to the repo.
This PR also adds the version and file version to the assemblies. It also
fixes the nuget package version for Sandwych.QuickGraph.Core.