-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Tame to collect more items & dt2 tablet fix #5578
Conversation
Preferably, in the future split things up into several PRs rather than grouping unrelated things together in 1 PR. It makes it much harder to review. |
No problem. How would you like this one split up? I figured since its all tame related I would keep it to 1 PR. |
The DT2 stuff seemed separate, maybe im wrong. |
monster: [BSOMonsters.VladimirDrakan.id], | ||
specialItems: [ | ||
{ | ||
item: [ | ||
itemID('Vampyre hunter boots'), | ||
itemID('Vampyre hunter legs'), | ||
itemID('Vampyre hunter top'), | ||
itemID('Vampyre hunter cuffs'), | ||
itemID('Vampyre hunter hat'), | ||
itemID('Vampyre hunter hat') | ||
], | ||
chance: [32, 32, 32, 32, 32] | ||
}, | ||
{ | ||
item: [itemID('Vampyric plushie')], | ||
chance: [250] | ||
}, | ||
{ | ||
item: [itemID('Echo')], | ||
chance: [1000] | ||
} | ||
] | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure im a fan of any of how this works. The thing I hate more than anything in code is having several sources of truth like this (e.g. if we change echo droprate, we now need to change it in 2 places and nobody will remember to do that in both).
For vladimir drakans case, you can use the original code just calling specialLoot. Also maybe do a quick check over all the other specialLoots to make sure nothing crazy will happen letting tames get that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least for echo I could use the globalDroprates.ts rate. I'll try some more stuff out and see what I can come up with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You dont need too, just call monster.specialLoot(). Check monsterActivity
The dt2 fix is what sort of stemmed the entire PR. The tablets are currently unobtainable because they got removed from oldschooljs and added as an effect under killable monster. So it gives Top Tame cl role a bit of an advantage. I'll split it into different PRs to address the different issues tho. |
Description:
Changes:
Other checks: