-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Refund of charges to Colosseum #5956
Conversation
Adds a refund of charges to the colosseum if you die before finishing
This comment was marked as outdated.
This comment was marked as outdated.
@ellipsis-dev can you review this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 506a234 in 39 seconds
More details
- Looked at
302
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_JiNjRazXk4kZriUP
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 506a234 in 38 seconds
More details
- Looked at
302
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/lib/degradeableItems.ts:437
- Draft comment:
The implementation ofrefundChargeBank
function is correct and handles the refund logic appropriately for degradeable items based on the charges in thechargeBank
. It properly updates the user's charge count and provides a detailed message about the refund. - Reason this comment was not posted:
Confidence changes required:0%
TherefundChargeBank
function indegradeableItems.ts
is designed to handle the refund of charges for degradeable items. It iterates over each item in thechargeBank
, finds the corresponding degradeable item, calculates the new total charges, and updates the user's data accordingly. The function also constructs a result message for each item, indicating the number of charges refunded and the new total. This function is crucial for ensuring that users are correctly refunded for their unused item charges, especially in scenarios like the Colosseum where users may not use all their charges before dying. The function appears to be well-implemented with checks for valid degradeable items and updates the user's data in the database.
Workflow ID: wflow_sqjWMn4KhmN4uXXi
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Adds a refund of charges to the colosseum if you die before finishing
Summary:
Added functionality to refund charges for specific items if a user dies before completing the Colosseum.
Key points:
scythe_of_vitur
,venator_bow
, andblood_fury
if a user dies before completing the Colosseum insrc/lib/colosseum.ts
.startColosseumRun
function insrc/lib/colosseum.ts
to include charge calculations.refundChargeBank
function insrc/lib/degradeableItems.ts
to handle the refund logic.colosseumCommand
insrc/lib/colosseum.ts
to pass charge information.ColoTaskOptions
interface insrc/lib/types/minions.ts
to include charge fields.colosseumTask
insrc/tasks/minions/colosseumActivity.ts
to process charge refunds on death.simulateColosseumRuns
insrc/mahoji/commands/simulate.ts
to include charge parameters.Generated with ❤️ by ellipsis.dev