Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QBD Boost fixes + Dragon Boost Mislabel fix #5998

Open
wants to merge 3 commits into
base: bso
Choose a base branch
from
Open

QBD Boost fixes + Dragon Boost Mislabel fix #5998

wants to merge 3 commits into from

Conversation

DaughtersOfNyx
Copy link
Contributor

Description:

Three different bugs fixed here relating to Dragons/QBD specifically.

Changes:

  1. Changed QBD's base monster from Vorkath -> KBD. This removes the incorrect application of Undead boosts to QBD (Salve amulet etc)
  2. Added a check before applying generic dragon boost to QBD similar to Vorkath that allows the Lance to actually provide its boost. Previously it was impossible to get the boost from lance as the boss requires range. This also involved explicitly adding the Dragon Hunter item boosts to QBD.
  3. Fixed the incorrect info in the show_info subcommand of /k from 20% -> 15% as this wasn't changed back when the boost was reduced I suppose. Already fixed in OSB.

Other checks:

  • I have tested all my changes thoroughly.

@github-actions github-actions bot added the BSO Bot School Old label Aug 12, 2024
@gc
Copy link
Collaborator

gc commented Oct 16, 2024

Has conflicts. Looks good to merge though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BSO Bot School Old Status: Waiting For Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaughtersOfNyx @gc