-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Armoured zombie #6140
Armoured zombie #6140
Conversation
run You could also add the fixed version of of zombie axe aswell to either /smith or /create, probably just use something like Dragonfire shield as the example. |
done. But I see one of the tests is still failing |
I re-ran the test, its good to go now. |
@@ -2501,6 +2501,14 @@ const Createables: Createable[] = [ | |||
outputItems: new Bank().add('Amulet of rancour').freeze(), | |||
noCl: true | |||
}, | |||
{ | |||
name: 'Zombie axe', | |||
inputItems: new Bank().add('broken zombie axe').freeze(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item names should always follow the osrs convention of Broken zombie axe
, or (if the item is in it), use EItem.ITEM_NAME
. I will merge without requesting a change because its not a big deal.
Description:
Add Armoured zombies
Changes:
Added Armoured Zombies as an option for zombie slayer tasks, used a few guides online to estimate a good kills p/h.
Added Broken zombie axe to misc cl
Allow barrage and chins
Looks like VScode is forcing the formatting in collectionExport is showing the line 39-41 changes. If it really bothers you let me know and I'll try and figure it out.
Also if there's some other step I'm forgetting let me know.
Other checks: