Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armoured zombie #6140

Merged
merged 6 commits into from
Oct 27, 2024
Merged

Armoured zombie #6140

merged 6 commits into from
Oct 27, 2024

Conversation

Felris
Copy link
Contributor

@Felris Felris commented Oct 18, 2024

Description:

Add Armoured zombies

Changes:

Added Armoured Zombies as an option for zombie slayer tasks, used a few guides online to estimate a good kills p/h.
Added Broken zombie axe to misc cl
Allow barrage and chins

Looks like VScode is forcing the formatting in collectionExport is showing the line 39-41 changes. If it really bothers you let me know and I'll try and figure it out.

Also if there's some other step I'm forgetting let me know.

Other checks:

  • I have tested all my changes thoroughly.

@nwjgit
Copy link
Contributor

nwjgit commented Oct 18, 2024

run yarn lint to correct the formatting issues.
run yarn test:unit -u to update the cl snapshot to fix the unit test.

You could also add the fixed version of of zombie axe aswell to either /smith or /create, probably just use something like Dragonfire shield as the example.

@Felris
Copy link
Contributor Author

Felris commented Oct 18, 2024

run yarn lint to correct the formatting issues. run yarn test:unit -u to update the cl snapshot to fix the unit test.

You could also add the fixed version of of zombie axe aswell to either /smith or /create, probably just use something like Dragonfire shield as the example.

done. But I see one of the tests is still failing

@nwjgit
Copy link
Contributor

nwjgit commented Oct 18, 2024

run yarn lint to correct the formatting issues. run yarn test:unit -u to update the cl snapshot to fix the unit test.
You could also add the fixed version of of zombie axe aswell to either /smith or /create, probably just use something like Dragonfire shield as the example.

done. But I see one of the tests is still failing

I re-ran the test, its good to go now.

@@ -2501,6 +2501,14 @@ const Createables: Createable[] = [
outputItems: new Bank().add('Amulet of rancour').freeze(),
noCl: true
},
{
name: 'Zombie axe',
inputItems: new Bank().add('broken zombie axe').freeze(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item names should always follow the osrs convention of Broken zombie axe, or (if the item is in it), use EItem.ITEM_NAME. I will merge without requesting a change because its not a big deal.

@gc gc merged commit d72d687 into oldschoolgg:master Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants