Prevent repeating kill trips when slayer task is finished #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did people agree/like this idea? |
Poll is pretty clear. The bot used to have this functionality but it was removed (unintentionally) a while ago, so to me it was a no-brainer.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add underlying
onTaskboolean to check if repeated monster killing trip is off task, but original trip was on task. If so, don't do the trip. Can then either get new task, or just use/kagain to kill the same monster if you really want to. There were other options, like a confirmation message, but probably unnecessary.#6185
Closes #5972.
Changes:
onTaskboolean toMonsterActivityTaskOptionsandminionKCommand, the latter only accessed via repeat trip.Other checks: