Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little nightmare fix #353

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

nwjgit
Copy link
Contributor

@nwjgit nwjgit commented Nov 15, 2023

closes: oldschoolgg/oldschoolbot#1023

Description:

  • Fixes Little nightmare drop rates.
    "The pet has a 1/800 drop rate in the original encounter, increasing by said amount for every additional player in the room when the fight started; 1/1600 in a duo, 1/2400 in a trio, 1/3200 in a 4-man and 1/4000 in a 5 or higher man encounter. At Phosani's Nightmare, the pet has a flat 1/1400 drop rate." Source: https://oldschool.runescape.wiki/w/Little_nightmare

Changes:

  • Makes Little nightmare drop scale based on party size.

  • 5% for MVP

  • "Mass nightmare" is capped at user + 3 simulated users but I still added a check to make sure this never goes above 4000.

  • I have tested all my changes thoroughly.

@nwjgit
Copy link
Contributor Author

nwjgit commented Nov 15, 2023

The commented out leagues Highscore checks are causing the test to fail. I'm guessing that's because Leagues 4 is releasing tomorrow and messing with the Highscores.

@nwjgit nwjgit marked this pull request as draft January 10, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Nightmare Pet Drop Rate
2 participants