Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Pharaoh's Sceptre tradeable #409

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Make Pharaoh's Sceptre tradeable #409

wants to merge 6 commits into from

Conversation

DayV-git
Copy link
Contributor

@DayV-git DayV-git commented Nov 18, 2024 •
edited
Loading

Description:

  • Current prep script links sceptre to 26_950 which is a non-tradeable version of new sceptre. Changed to 26_945. The name of this item is 'Pharaoh's Sceptre (uncharged)' but I manually changed it back to existing name for compatibility with osb. As the ID hasn't changed, everyone's sceptres should be tradeable after this. Though the price doesn't seem to be updated in item_data, so it will have \sell price 0, it can be sold on ge.
    Edit: I added code to change the price based on correct ID, it worked once but then the price went back to 0, i don't know why.

Changes:

  • Make Pharaoh's Sceptre tradable by changing underlying ID to tradable version

  • I have tested all my changes thoroughly.

@DayV-git DayV-git mentioned this pull request Nov 18, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DayV-git