feat: Support for GDPR compliant google font usage #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 🙌 Do you have any good reasons for why this should be a toggle? Wouldn't it be better to just always serve the font "loacally" instead of from a cdn? |
|
Well... fonts are best served from CDNs. Theoretically, people can also host digital garden in other platforms where they might not have global CDNs. Loading fonts from CDN might be better for them. |
|
@oleeskild we can do away with google fonts entirely though. Bootstrap's native font stack is pretty solid. We can just use that. For everything else, users can add their fonts. https://getbootstrap.com/docs/5.3/content/reboot/#native-font-stack |
|
However, I found that it will be a problem with the extensive styles obsidian itself provides. So GDPR toggle is probably a much better option. |
uroybd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle to choose whether the default google font shipped with the template (namely Roboto) will be served from a locally downloaded version or Google's CDN. This will allow it to be GDPR compliant.
#196