Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Will you make a version for Foundation 6? #556

Closed
lennoxivius opened this issue Nov 19, 2015 · 57 comments
Closed

Will you make a version for Foundation 6? #556

lennoxivius opened this issue Nov 19, 2015 · 57 comments
Labels

Comments

@lennoxivius
Copy link

Foundation 6 just launched today, so i was wondering whether you have any plans of supporting Foundation 6, and if so when. And thank you for FoundationPress

@olefredrik
Copy link
Owner

FoundationPress will be updated to the Foundation 6 soon. Older versions (based on Foundation 5) will still be available in the release archive when the new version is released.

@ghost
Copy link

ghost commented Nov 19, 2015

Foundation 6 looks incredible! Can't wait to see your Foundation6Press 👍

@olefredrik
Copy link
Owner

I agree there. Great kudos to the team at Zurb. They've done a massive job with the F6 release. I like what I've been seing so far. That said, I have found that it is always wise to wait a little while before starting migration to new major versions, as there usually are many updates and patches the first few weeks after a major release.

@jonasopdebeeck
Copy link

Thumbs up for making the effort of updating, @olefredrik ! Looking forward to FoundationPress based on Foundation 6!

@Luciaisacomputer
Copy link
Contributor

@olefredrik thanks again for your contributions, I continue to use FoundationPress on every WP site I build and the addition of Foundation 6 is going to make everything even better! 👯

@olefredrik
Copy link
Owner

👍

@illusivesunrae
Copy link

@olefredrik Do you have a rough estimate on when you'll have an updated version? Thanks! :)

@AdamChlan
Copy link
Contributor

@olefredrik I don't know your plans to roll out the theme, but if it makes sense to set up task/issues in the tracker, I'd be happy to contribute to get tasks completed.

@t-fulton
Copy link

Smart about waiting until the F6 kinks are ironed out, thanks for a fantastic theme!

@colin-marshall
Copy link
Collaborator

@olefredrik if you need assistance with the migration or beta testers for the Foundation 6 version of FoundationPress, please let us know how we can help.

@olefredrik
Copy link
Owner

Thanks @colin-marshall ! I'm in the process of upgrading FP to Foundation v6.0.1 as we speak. So far it looks good. But there is some work to be done before it is ready for release. I will push the development branch when it's ready for beta testing. Stay tuned :)

@colin-marshall
Copy link
Collaborator

Thanks!

@tomhermans
Copy link

Wanted to know this as well. Thanks for the reply I was hoping for. Awesome work !

@olefredrik
Copy link
Owner

Current status: Attempting to be smarter than I actually am. Build script now compiles all F6 assets without errors. Next: Topbar and offcanvas navigation. And coffee. Lots of coffee.

2015-11-21 00 58 55

@olefredrik
Copy link
Owner

Current status <-- Not too far away from the truth, actually.

But seriously. I have made some progress through the weekend. There are still some challenges around top bar and offcanvas navigation. It works, but far from perfect. I also have some challenges with Magellan and Sticky plugins.

I don't want to drop a new major release until everything has been tested and works fairly well.

@arielnoname
Copy link

@olefredrik Nice work man, and very nice working place. Thanks for taking the time so we all can enjoy this.

@Aetles
Copy link
Contributor

Aetles commented Nov 22, 2015

Well, Zurb have already released four versions of Foundation 6 in just a couple of days (6.0.0 -> 6.0.3) so it is probably a good thing to take your time and not rush out a new major release.

@Luciaisacomputer
Copy link
Contributor

@olefredrik , let me buy you a coffee!

@stirlingsohn
Copy link

yeah where can we donate? FoundationPress is King!

@olefredrik
Copy link
Owner

Haha, thank you! The whole project is based on good teamwork, so it would be wrong to accept donations. But if you are happy with FP, please feel free to donate a buck for a good cause (Red Cross, Amnesty International, or similar) on behalf of yourself and all awesome contributors to the project.

@dantahoua
Copy link
Contributor

Thanks a lot for your work! FoundationPress saved me some precious time. With Foundation 6 it seems more time will be saved (with animation and menu!).

@jimlongo56
Copy link
Contributor

Really looking forward to FoundationPress with Foundation 6.

We're using a slightly customized version on all our sites now - adding required plugins and added dependencies. We're even requiring outside design shops to start with a branch of our FoundationPress. Makes maintenance and further development a snap.

Thanks for your efforts on this!

@joshrathke
Copy link
Contributor

Thanks for your work on this @olefredrik, this starter theme is one for the books and bringing into the 6.0 generation is only going to make it stronger!

@brycejacobson
Copy link

Thanks for everything you do. Looking forward to the version 6 release!

@ghost
Copy link

ghost commented Nov 26, 2015

Thank you so much for preparing these goodies for us @olefredrik.
What puzzles me, is FoundationPress going to remain grunt-powered in the future?

@olefredrik
Copy link
Owner

@eccola : As of now, I'm still using Grunt. Although Zurb have switched to Gulp on Foundation 6, I'm not sure if we were going to replace something that works for us. Both Grunt and Gulp works quite well, imo. As long as we use libsass, compiling will be fast either we use one or the other. My focus now is not on switching task runner technology, but to get all F6 components to work with WordPress. But I'm open to a discussion around this, if anyone has really good arguments for switching to Gulp.

@alexbohariuc
Copy link
Contributor

@olefredrik count me in for testing.
Great job!

@radel
Copy link
Contributor

radel commented Nov 26, 2015

@olefredrik the only argument I can think of for switching to Gulp is consistency with foundation, both in workflow and directory tree. We could take the good work the foundation team has done and use it in FoundationPress with little adjustments. In the long run, keeping up with Grunt could be much harder than just pull the gulpfile from foundation-sites.
Also, I can't wait to get my hands dirty and help you in a development branch :)

keep up the great work!

@colin-marshall
Copy link
Collaborator

I vote for a switch to Gulp. The consistency argument is an important one. A fair number of your users probably learned and used Foundation before learning and using FoundationPress. Those people will be more comfortable with FoundationPress from the get go if you're using the same build system that they learned to use with Foundation. A lot of users will never touch the build system, but you'll make life easier for those who do if you are on the same task runner/build system that Foundation is using.

@ghost
Copy link

ghost commented Nov 27, 2015

I'd love to have "the original" FoundationPress kept intact from the task runner change.
How's about creating a new branch of FoundationPress with gulp build bells and whistles?
It would sure grow the user and the contributor base.

@radel
Copy link
Contributor

radel commented Nov 27, 2015

@eccola they can coexist, in the end they are just two files in your project root and and you can run whatever you want.

@jimlongo56
Copy link
Contributor

I'm familiar with the current process, and lazy, so stay with Grunt. But I'm not religious about it - it's no big deal either way, a hour or so to learn enough about Gulp or Grunt to work with FP.

As far as I can see, the main pro for Gulp is speed, but the time taken for the tasks I have running currently is not slowing my workflow down.

@joshrathke
Copy link
Contributor

The original FoundationPress would always be available through the last
release using Grunt if the change to Gulp was ever made. I think trying to
manage two different Forks would be pretty inefficient. One would end up
lagging WAY behind. I would say if it's time to move on, then it's time to
move on.

On Friday, November 27, 2015, Eccola notifications@github.com wrote:

I'd love to have "the original" FoundationPress kept intact from the task
runner change.
How's about creating a new branch of FoundationPress with gulp build bells
and whistles?
It would sure grow the user and the contributor base.


Reply to this email directly or view it on GitHub
#556 (comment)
.

Josh Rathke
I.T. Director & Web Developer, YWAM Montana | Lakeside
p: (406) 844-2221 m: (765) 637-5847 a: 501 Blacktail Rd. Lakeside MT, 59922
s: www.ywammontana.org e: josh.rathke@ywammontana.org

@colin-marshall
Copy link
Collaborator

2 forks would be a pain, I agree.

Maybe the question if Grunt should be replaced by Gulp in FoundationPress should also be asked to the Foundation devs at Zurb. They would know better than anybody else if there would be an issue/conflict down the road with FoundationPress continuing to use Grunt for future releases.

@joshrathke
Copy link
Contributor

I think there is a conversation on whether to move to Gulp or not. But I think that's where it needs to end.

I agree with Colin. Multiple Forks would present some issues in terms of slowing down feature releases due to having to make everything work on both. The alternative is one quietly dies anyway, while a bunch of people get frustrated it isn't ever being updated.

I also wouldn't want to have multiple task runners within the project side by side. That get's confusing documentation-wise, and could potentially screw peoples projects up if they work on many different projects and switch from one to another, then have to remember which one they were using in a "FoundationPress Built" project.

Like I said above, my vote would be that if we decide consistency with Zurb is king, then let's not try to hang on to the past. Let's move on full steam ahead. Old projects will still function just fine. New projects will function better.

We have to consider what FoundationPress is at it's core. It's a turnkey development theme for people wanting to develop WordPress themes with Foundation at the core. The whole point is for it to be as least complicated and as consistent with Zurb's current model as possible. At the end of the day, someone should only need to consult the documentation on FoundationPress at the initial installation, and then be able to transition over to Zurb's documentation entirely. Anything else is a sign of over-complication.

@arielnoname
Copy link

I think the consistency argument takes it all. I've never used Gulp before but if Zurb is changing Grunt and to that we sum up the speed thing, it's a winner.

@ryankidd
Copy link

Looking forward to it. Thanks team FP!

@jorcons
Copy link

jorcons commented Nov 30, 2015

I prefer Grunt but if you decide move to Gulp it's ok. Great work guys! I use FoundationPress on most of my projects. It's awesome!

@Tralapo
Copy link
Contributor

Tralapo commented Dec 2, 2015

Don't have much to say about Grunt vs. Gulp, I'm fine with both I think. Keep up the good working, looking forward to FP based on F6!

@Aetles
Copy link
Contributor

Aetles commented Dec 2, 2015

For anyone familiar with Grunt but not Gulp, here's a good start: Switching from Grunt to Gulp.

@swthate
Copy link

swthate commented Dec 2, 2015

Thanks for the link, @Aetles!

saves to favorites

@jorcons
Copy link

jorcons commented Dec 2, 2015

Good article @Aetles. Thanks! I'm looking forward too for FP with F6.

@mhair
Copy link

mhair commented Dec 3, 2015

Looking forward to the beta testing the development branch as well! Great starter theme, and Foundation 6 is going to be a nice step forward!

@imaginethepoet
Copy link

Like the rest here happy to test or look at some code tasks. I've been working with foundation 6 a little before public release. Share the challenges you are having and i believe this group will help out. If you have a beta branch up we can look at that. Great work.

@olefredrik
Copy link
Owner

Ta-da! #580

@jorcons
Copy link

jorcons commented Dec 5, 2015

Esta dirección en breve dejará de funcionar.
Rogamos tome nota del nuevo email: jconstanti@visibletic.com

Visible IT Comunicación
visibletic.com

@swthate
Copy link

swthate commented Dec 5, 2015

And there was much rejoicing!!

Bravo

Much Rejoicing

@olefredrik
Copy link
Owner

I have not prioritized a switch from Grunt to Gulp yet. But it may be added over time. Enjoy! :)

@joshrathke
Copy link
Contributor

This is awesome! Thank you for what had to be hours and hours of tinkering!

Josh Rathke
I.T. Director & Web Developer, YWAM Montana | Lakeside
p: (406) 844-2221 m: (765) 637-5847 a: 501 Blacktail Rd. Lakeside MT, 59922
s: www.ywammontana.org e: josh.rathke@ywammontana.org

On Fri, Dec 4, 2015 at 6:45 PM, Ole Fredrik Lie notifications@github.com
wrote:

I have not prioritized a switch from Grunt to Gulp yet. But it may be
added over time. Enjoy! :)


Reply to this email directly or view it on GitHub
#556 (comment)
.

@imaginethepoet
Copy link

Great

@colin-marshall
Copy link
Collaborator

@olefredrik: Nice work! I've already started adding Gulp on a branch of my FoundationPress Fork. I have the JS and Sass tasks working and will work on the rest over the weekend. I'll make a PR when it's more complete so you can check it out and decide if you want to use it.

@josh-rathke: Hello fellow Montanan! Missoulian here. Never in a million years did I think I would see anybody else from Montana on this. Cheers!!!

@olefredrik
Copy link
Owner

@colin-marshall : Sweet! Looking forward to reviewing your pull request with Gulp 👍

@colin-marshall
Copy link
Collaborator

Just thought I would post one last time in this thread to let everybody know that the switch to Gulp has happened. Test it out and feel free to @ me in any Gulp related issues you open so I can assist.

@jorcons
Copy link

jorcons commented Dec 7, 2015

Great Collin! Thanks for you work. I'll try and give you feedback.

@joshrathke
Copy link
Contributor

@colin-marshall That's awesome! And yeah that's crazy about you being in Montana as well. Definitely not a lot of coders out here. I have met a couple pretty darn good ones up here in Kalispell though.

Nice work man, this will make future projects incredible!

@Aetles
Copy link
Contributor

Aetles commented Mar 16, 2016

Just a quick follow-up, looking back at this now…

Back in November when we discussed the move to Foundation 6 I was a little cautious not to rush out this new major release since I felt that Zurb was still moving a little too fast. Looking back, I think Foundation 6 has hade somewhat of a rocky road since then, compared to the stability we were used to with Foundation 5. This has now been acknowledged by Zurb in an answer to some frustrated users in another issue:

We hear your issues—know that we're working on it. We moved a little too fast the last three months, and our intent for the near future is to slow down and stabilize.

This is good news for us. They have also started with more testing and intend to bring in more people from the community:

You might have noticed that we've started writing visual regression tests as we address bugs. We've also published a full testing guide and started an initiative to build out a JavaScript test suite.

We also intend to soon bring in members of the community to be direct contributors to the codebase, help review pull requests, and so on. So we're gradually moving towards a system where decisions are made in a more deliberate manner, by a larger group of people. Foundation 6 was an aggressive reset to the structure of the codebase, with an eye towards making it more sustainable long-term.

@jorcons
Copy link

jorcons commented Mar 16, 2016

Esta dirección en breve dejará de funcionar.
Rogamos tome nota del nuevo email: jconstanti@visibletic.com

Visible IT Comunicación
visibletic.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests