Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Misc changes to consider #708

Closed
Aetles opened this issue Feb 5, 2016 · 5 comments
Closed

Misc changes to consider #708

Aetles opened this issue Feb 5, 2016 · 5 comments

Comments

@Aetles
Copy link
Contributor

Aetles commented Feb 5, 2016

In my (now heavily modified) fork of FoundationPress I have a branch were I kept some changes that could be brought back to FoundationPress if it is something others like, before I started to made more sever changes for my own need.

I'm not gonna create a bunch of PR:s unless there is a real demand for it, because a lot of the changes is more personal preference that necessary change. Instead I'm listing them here and you can decide if this is something for FoundationPress. (Stuff like moving files and renaming folder could create confusions for other users, for example.)

Most of these changes are self-explanatory, I think, but further motivation/explanation for these changes are in some of the commit descriptions.

@olefredrik
Copy link
Owner

@Aetles : All of the changes you listed above makes sense to me. If you could create pull requests, I will gladly merge your changes into the master branch.

@Aetles
Copy link
Contributor Author

Aetles commented Feb 8, 2016

I have busy week but I'll give it a try this weekend! (Actually never made a PR before, so I'm not promising anything 😄 )

@colin-marshall
Copy link
Collaborator

@Aetles I put in the pull request for you. Your post made it very easy for me to merge in all your commits so you will get all the credit. Thanks for helping out!

PR: #717

@Aetles
Copy link
Contributor Author

Aetles commented Feb 9, 2016

Oh, nice! Thanks!

@olefredrik
Copy link
Owner

Merged #717

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants