Adagio improvements #717

colin-marshall · 2016-02-09T05:45:05Z

Credit to @Aetles.

This is no longer needed. More info: http://stackoverflow.com/questions/20716490/apple-touch-icon-precomposed-is-not-a-real-value-for-the-rel-attribute h5bp/html5-boilerplate#1615 google/web-starter-kit#492

@Package

"@Package Wordpress" is only for core-bundled themes, this is a standalone package. More info: http://wordpress.stackexchange.com/questions/82787/package-subpackage-how-to-use-with-child-themes

WordPress recommends this: "Omitting the closing PHP tag at the end of a file is preferred." https://make.wordpress.org/core/handbook/coding-standards/php/#remove-trailing-spaces

(Taken from Underscores.)

This is the recommended name here: https://developer.wordpress.org/themes/basics/organizing-theme-files/#page-templates-folder and here: http://themefoundation.com/naming-wordpress-theme-folders-files/

It is better description and this is what Underscores does.

This is a personal preference. It is allowed in javascript (since ES5). The trailing commas reduces risk of copy-paste errors and it makes the diffs looks cleaner (no touching of other lines when adding/removing entries in arrays).

Both content.php and content-none.php are template parts and therefore it is more logical to place them in template-parts folder. (Underscores does this too, but not default themes like TwentyTwelve.)

Adagio improvements

Aetles added 8 commits February 8, 2016 22:39

Remove "precomposed" from Apple touch icons

30490ba

This is no longer needed. More info: http://stackoverflow.com/questions/20716490/apple-touch-icon-precomposed-is-not-a-real-value-for-the-rel-attribute h5bp/html5-boilerplate#1615 google/web-starter-kit#492

Use @Package for theme name, not @subpackage

f6fc8d3

"@Package Wordpress" is only for core-bundled themes, this is a standalone package. More info: http://wordpress.stackexchange.com/questions/82787/package-subpackage-how-to-use-with-child-themes

Omit the closing PHP tag at the end of files

8803278

WordPress recommends this: "Omitting the closing PHP tag at the end of a file is preferred." https://make.wordpress.org/core/handbook/coding-standards/php/#remove-trailing-spaces

Use bloginfo charset instead of hard coded utf-8

f92487e

(Taken from Underscores.)

Rename page template folder to "page-templates"

f714f33

This is the recommended name here: https://developer.wordpress.org/themes/basics/organizing-theme-files/#page-templates-folder and here: http://themefoundation.com/naming-wordpress-theme-folders-files/

Rename template parts folder to "template-parts"

8a07677

It is better description and this is what Underscores does.

Add trailing commas to gulpfile.js

b08c4eb

This is a personal preference. It is allowed in javascript (since ES5). The trailing commas reduces risk of copy-paste errors and it makes the diffs looks cleaner (no touching of other lines when adding/removing entries in arrays).

Move template parts to template-parts folder

e32b83f

Both content.php and content-none.php are template parts and therefore it is more logical to place them in template-parts folder. (Underscores does this too, but not default themes like TwentyTwelve.)

colin-marshall mentioned this pull request Feb 9, 2016

Misc changes to consider #708

Closed

olefredrik added a commit that referenced this pull request Feb 11, 2016

Merge pull request #717 from colin-marshall/adagio-improvements

673ad70

Adagio improvements

olefredrik merged commit 673ad70 into olefredrik:master Feb 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adagio improvements #717

Adagio improvements #717

colin-marshall commented Feb 9, 2016

Adagio improvements #717

Adagio improvements #717

Conversation

colin-marshall commented Feb 9, 2016