Updated Action Hooks and Classes for Wordpress Coding Standards

[joshrathke]

Also fixed a couple “yoda condition” issues to make unit testing pass.

[Aetles]

This change seems wrong, previously it was
$element->has_children && $max_depth !== 1
and now it is
1 !== $element->has_children && $max_depth
shouldn't it rather be
$element->has_children && 1 !== $max_depth
?

[Aetles]

Also, and I feel like I am nitpicking here, but if we are to follow coding standards then The WordPress Naming Conventions say this about naming classes:

Class names should use capitalized words separated by underscores.

[joshrathke]

@Aetles you were totally right. I completely missed that in the menu walkers. It had actually happened in menu-walker.php as well, but I went ahead and changed it. Both are now fixed and read:

$element->has_children && 1 !== $max_depth

Also thanks for reminding me of the true WP Standards definition for classes. I don't know why I was under the impression that it Classes were to be camel-case. Either way, it should all be changed now. I think I hit all the classes, but might need to have a double check on that.

The only thing that remains in question in my mind would be the text domain. WordPress doesn't seem to have a standard for the text-domain. However in the I18n Documentation found here it does state the following under the text domain section:

If you're translating a plugin or a theme, you'll need to use a text domain to denote all text belonging to that plugin. This increases portability and plays better with already existing WordPress tools. The text domain must match the “slug” of the plugin.

So I guess my last question is if we need to change the FoundationPress text domain to foundationpress, just to go the extra mile. I don't believe capital letters are ever translated into any slug.

[Aetles]

Great! About the text domain: I'd vote for changing FoundationPress to foundationpress as that is more "slug-like".

[joshrathke]

@olefredrik What do you think about the text domain change?

[olefredrik]

I agree that it could be okay to change the text-domain to foundationpress, as long as this change does not affect any existing translations (I see no reason why it should). In all cases, the FoundationPress repository is now build passing, due to your great contributions. Well done, guys! You are awesome!