This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fixed: The off-canvas mobile menu was not working correctly #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he correct side was not set when calling 'foundationpress_mobile_off_canvas' (therefor the side always defaulted to 'left')
|
👍 |
|
You forgot to merge, or did you fix it already in your branch? :) |
olefredrik
added a commit
that referenced
this pull request
Sep 4, 2015
…_the_right_(currently_only_left_possible) Fixed: The off-canvas mobile menu was not working correctly
|
Added a bug label, gave a thumbs up and closed it. Haha, I need more coffee. Well thank you :) |
|
Hehe, git should have known that you wanted to merge, hehe. Bad programming on their parit ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the correct side was not set when calling 'foundationpress_mobile_off_canvas' (therefore the side always defaulted to 'left')
This prevented second level menus from being displayed correctly.