Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting RegistrySearch Id causes infinite loop #1096

Closed
austinw-fineart opened this issue Nov 26, 2021 · 5 comments
Closed

Setting RegistrySearch Id causes infinite loop #1096

austinw-fineart opened this issue Nov 26, 2021 · 5 comments

Comments

@austinw-fineart
Copy link

The RegistrySearch Id setter sets itself, thus causing an infinite loop:

new public string Id { get => base.Id; set => Id = value; }

@oleg-shilo
Copy link
Owner

Yes it is a bug :(
A very nasty typo.
Thank you for reporting.

Fixed

Until the fix is published please use base class to set the property.

@austinw-fineart
Copy link
Author

Well I found another one traversing base classes 😅

@oleg-shilo
Copy link
Owner

oleg-shilo commented Dec 5, 2021

Oh my. And Source/src/WixSharp/FileSearch.cs
And some more

image
Will do the comprehensive dig.
Thank you for letting me know

@oleg-shilo
Copy link
Owner

Done. Another two:
image

May I ask you a favor? Can you please check again. I did a global search but another pair of eyes would not hurt.

Txs

@austinw-fineart
Copy link
Author

Yes I do believe that's all of the recursive setters I could find 👍

oleg-shilo added a commit that referenced this issue Mar 1, 2022
- Added WPF stock dialogs for Custom UI (WixSharp.Ui.WPF assembly)
- Added test case for #1114
- Issue #1087: Intermittent error
- "WixSharp Project Templates" extension is ported to VS2022
- Issue #1096: Setting RegistrySearch Id causes infinite loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants