Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in Compiler.cs comments #562

Closed
monty241 opened this issue Jan 9, 2019 · 0 comments
Closed

Typo in Compiler.cs comments #562

monty241 opened this issue Jan 9, 2019 · 0 comments
Labels
Done / Released enhancement

Comments

@monty241
Copy link
Contributor

monty241 commented Jan 9, 2019

The Compiler.cs lists:

     /// <code>
     /// var project = new Project();
     /// ...
     /// Compiler.BuildWxsCmd(project);
     /// </code>

However, BuildWxsCmd should probably be replaced by BuildMsiCmd.
oleg-shilo pushed a commit that referenced this issue Jan 10, 2019
@lbs-contributor
Issue #562: Typo in Compiler.cs comments
5bd0b4d
oleg-shilo pushed a commit that referenced this issue Jan 19, 2019
@lbs-contributor
Release v1.9.4
a7dde72 
* VS project templates - added packages.config files
* Added Condition-s for .NET Frameworks 4.7.1 and 4.7.2
* Issue #569: Updating WixSharp leads to malfuncion of SetEvVar
* Added support for `UI.Error` WiX element
* Issue #552: Question: Install 2 windows services in same installer
* Issue #541: Installing 2 Services in the same installer results in …
* Samples update
* Issue #560: Semantic difference between UninstallCondition and IsUninstalling
* Issue #564: Correct variable name of SequentialGuid initialization.
* Issue #562: Typo in Compiler.cs comments
* Issue #561: Typo in WixProject.cs
* Added missing namespace in custom dialog template, fixed comment.
* Added explicit `WixEntity.ComponentId` property
* Issue #551: Cannot include extra .wxs as part of a bundle
* Issue #542: ServiceInstaller.StartOn/StopOn/RemoveOn - Documentation bug
* Issue #544: Failed while processing WebSites; added support for `IISVirtualDir.AttributesDefinition`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Done / Released enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monty241 @oleg-shilo