Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ampersand character (&) as xml delimiter #645

Closed
noctis0430 opened this issue May 17, 2019 · 0 comments
Closed

Add ampersand character (&) as xml delimiter #645

noctis0430 opened this issue May 17, 2019 · 0 comments
Labels
bug Done / Released

Comments

@noctis0430
Copy link
Contributor

Existing xml delimiters defined in Extensions.cs only include < and >.

static char[] xmlDelimiters = "<>".ToCharArray();

Propose to include ampersand character (&) to handle conditional string such as &feature_name=3 as been seen here.
oleg-shilo pushed a commit that referenced this issue May 17, 2019
@lbs-contributor
Issue #645: Add ampersand character (&) as xml delimiter
3373d4b
oleg-shilo pushed a commit that referenced this issue May 18, 2019
@lbs-contributor
Release v1.9.8
8e71e15 
- Issue #645: Add ampersand character (&) as xml delimiter
- `WixSharp.Extensions` class that is implemented in both _WixSharp.dll_ and _WixSharp.Msi.dll_ is refactored to
`WixSharp.Msi.Extensions` ifor the _WixSharp.Msi.dll_ assembly. This is done in order to avoid ambiguety when using both assemblies at the same time.
  While it is a breaking change it is very easy to handle one and requires only an update in the _using_ clause:
  ```C#
  using WixSharp.Msi;
  // instead of old "using WixSharp;"
  ```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Done / Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oleg-shilo @noctis0430