fix: use correct options object & set fallback context

[herschel666]

Hey, I have two fixes here. :-)

[olegstepura]

Could you please describe what it fixes

[herschel666]

When using the loader with webpack@4.1.1 on node@8.9.1 I'll get the following error:

TypeError: Cannot read property 'context' of undefined

My guess was, that this is related to treating the options as an instance variable, while it's actually a local variable. After fixing that, I got the following error:

TypeError: Path must be a string. Received undefined

This is because options.context, which is passed into path.relative(), is undefined. My take was to set the falback for context to process.cwd().

An alternative approach would be to fall back to an empty string:

- this.emitFile(path.relative(options.context, content.outputFilePath), content.contents || [''], map);
+ this.emitFile(path.relative(options.context || '', content.outputFilePath), content.contents || [''], map);

What do you think?

[olegstepura]

Did you try to use queryOptions to define options.context to fix you issue?

[herschel666]

No, since it's not a required option parameter.

[unstubbable]

I'm also interested in this fix. In my opinion the proposed solution makes sense. Setting the context via query options does not work, unless at least the second part of this PR is accepted:

- this.emitFile(path.relative(this.options.context, content.outputFilePath), content.contents || [''], map);
+ this.emitFile(path.relative(options.context, content.outputFilePath), content.contents || [''], map);

[unstubbable]

Looking at other PRs (like this one or this one), I think this is the correct fix:

- this.emitFile(path.relative(this.options.context, content.outputFilePath), content.contents || [''], map);
+ var context = options.context || this.context || this.rootContext;
+ this.emitFile(path.relative(context, content.outputFilePath), content.contents || [''], map);

And also initialising options with an empty object (var options = {};).

[unstubbable]

Looks good to me.

[herschel666]

@KingHenne man, you're fast! :-D

[olegstepura]

Ok, merged and released 0.0.12