Add support for VS 2019 #60

peterM · 2019-04-04T06:31:23Z

Hi,

I updated source code of T4Toolbox to be possible use it with VS 2019.

I also think this should not be merged to current repository and instead of this should have its own repository.

I am also not for 100% sure if i changed all needed fields.

Thanks

#59

…t' test

hippasus · 2019-04-04T16:15:10Z

hi @peterM any complied vsix file link?

peterM · 2019-04-04T19:38:53Z

hi @hippasus, you just need clone my branch and build it. Then vsix will be saved in bin folder I can provide one but i am not sure if it is right way how to do it. I am new in open source and I do not want to do something wrong way.

3milio · 2019-04-05T19:37:39Z

Thanks for this idea @peterM! I was able to clone, build, and install from the .VSIX as you mentioned. I only have two issues: 1) VS 2019 is complaining about this extension loading synchronously, and 2) I couldn't resolve the error "The service 'Microsoft.Internal.VisualStudio.Shell.Interop.SVsUIThreadInvokerPrivate' must be installed for this feature to work. Ensure that this service is available" when trying to run the tests. But for now, this appears to be a viable short-term solution.

peterM · 2019-04-06T05:35:51Z

Hi @3milio, Thank you for your input. I will try to look on issues. Maybe i will be able to solve them.

Could you more describe 2nd issue (steps to reproduce)? I did not experience it.

3milio · 2019-04-12T18:50:58Z

@peterM, sorry for the delay in responding.
I simply chose (in VS 2019) to 'Run All' tests and got the error for just the integration tests. All other tests pass, or are skipped. And this is the error they get.

peterM · 2019-04-15T05:56:09Z

@3milio I will try. To be honest on my computer did not work tests .. but when i commited code and pull requests checks triggered build it was after several attempts green :)
Also this could be connected with VSSDK. Did you install also VS Extensibility packages?

Last week I tried migrate extension to support Asynchronous loading, but is not so easy to change inheritance from Package to AsyncPackage.
I had extension file, but Visual studio started to be unstable and extension unreliable :/

peterM · 2019-04-23T06:19:34Z

BTW: Visual studio 2019.1 will probably stop support loading synchronous packages so it will need to implement AsyncPackage instead of Package

ben1628 · 2019-05-28T12:44:04Z

new to this GitHub, how do I pull your branch?

peterM · 2019-05-28T12:58:59Z

new to this GitHub, how do I pull your branch?

execute git clone https://github.com/peterM/T4Toolbox.git

hbailles3 · 2019-07-29T18:51:29Z

Any way this could get merged or a new repository added so others can access it via VS 2019? Thanks peterM for doing this! I just pulled down your version to run the install and it worked great, but would be nice not to have to do that.

imran517 · 2019-08-15T14:19:38Z

What is the plan for official release for VS 2019?

SpartanDigitalDotNet · 2019-08-15T18:59:59Z

Thanks for doing this @peterM
When I loaded the solution on a Win10 / VS2019 dev box, VS complained that it wanted .Net 3.5. I went ahead and it still wouldn't build.

Here's the build log:

1>------ Rebuild All started: Project: T4Toolbox, Configuration: Debug Any CPU ------
2>------ Rebuild All started: Project: T4Toolbox.VisualStudio.ItemTemplates, Configuration: Debug Any CPU ------
1>  T4Toolbox -> C:\dev\src\spikes\T4Toolbox\src\T4Toolbox\bin\Debug\T4Toolbox.dll
3>------ Rebuild All started: Project: T4Toolbox.TemplateAnalysis, Configuration: Debug Any CPU ------
4>------ Rebuild All started: Project: T4Toolbox.DirectiveProcessors, Configuration: Debug Any CPU ------
5>------ Rebuild All started: Project: T4Toolbox.Tests, Configuration: Debug Any CPU ------
3>C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\TemplateScanner.partial.cs(39,30,39,37): error CS0115: 'TemplateScanner.yyerror(string, params object[])': no suitable method found to override
3>C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\TemplateScanner.partial.cs(61,47,61,55): error CS0246: The type or namespace name 'ScanBuff' could not be found (are you missing a using directive or an assembly reference?)
3>C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\TemplateScanner.partial.cs(79,33,79,36): error CS0115: 'TemplateScanner.TemplateBuffer.Pos': no suitable method found to override
3>C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\TemplateScanner.partial.cs(85,33,85,37): error CS0115: 'TemplateScanner.TemplateBuffer.Read()': no suitable method found to override
3>C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\TemplateScanner.partial.cs(108,36,108,45): error CS0115: 'TemplateScanner.TemplateBuffer.GetString(int, int)': no suitable method found to override
6>------ Rebuild All started: Project: T4Toolbox.VisualStudio.Editor, Configuration: Debug Any CPU ------
7>------ Rebuild All started: Project: T4Toolbox.TemplateAnalysis.Tests, Configuration: Debug Any CPU ------
6>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
8>------ Rebuild All started: Project: T4Toolbox.VisualStudio.Editor.Tests, Configuration: Debug Any CPU ------
4>  T4Toolbox.DirectiveProcessors -> C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.DirectiveProcessors\bin\Debug\T4Toolbox.DirectiveProcessors.dll
9>------ Rebuild All started: Project: T4Toolbox.VisualStudio, Configuration: Debug Any CPU ------
8>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
8>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio.Editor\bin\Debug\T4Toolbox.VisualStudio.Editor.dll' could not be found
9>C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(2114,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Build.Framework" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed.
9>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
9>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio.Editor\bin\Debug\T4Toolbox.VisualStudio.Editor.dll' could not be found
10>------ Rebuild All started: Project: T4Toolbox.vsix, Configuration: Debug Any CPU ------
5>  T4Toolbox.Tests -> C:\dev\src\spikes\T4Toolbox\test\T4Toolbox.Tests\bin\Debug\T4Toolbox.Tests.dll
11>------ Rebuild All started: Project: T4Toolbox.VisualStudio.Tests, Configuration: Debug Any CPU ------
10>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
10>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio\bin\Debug\T4Toolbox.VisualStudio.dll' could not be found
10>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio.Editor\bin\Debug\T4Toolbox.VisualStudio.Editor.dll' could not be found
12>------ Rebuild All started: Project: T4Toolbox.VisualStudio.IntegrationTests, Configuration: Debug Any CPU ------
7>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
12>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio\bin\Debug\T4Toolbox.VisualStudio.dll' could not be found
12>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio.Editor\bin\Debug\T4Toolbox.VisualStudio.Editor.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.TemplateAnalysis\bin\Debug\T4Toolbox.TemplateAnalysis.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio\bin\Debug\T4Toolbox.VisualStudio.dll' could not be found
11>CSC : error CS0006: Metadata file 'C:\dev\src\spikes\T4Toolbox\src\T4Toolbox.VisualStudio.Editor\bin\Debug\T4Toolbox.VisualStudio.Editor.dll' could not be found
========== Rebuild All: 4 succeeded, 8 failed, 0 skipped ==========

peterM · 2019-08-21T12:17:18Z

Here is built extension
T4Toolbox.0.0.0.0.zip

peterM · 2019-08-22T05:24:30Z

What is the plan for official release for VS 2019?

Hmm is hard to say because i think original author do not have time to maintain this. Hopefuly someone will take it. Currently i also do not have time to properly migrate this extension to fully support VS2019

niconico49 · 2019-09-27T08:39:22Z

After installed T4Toolbox.0.0.0.0.zip in vs 2019 preview 16.4.0 there is some problem with include once="true"
because "once" attribute is not recognized

mika76 · 2019-10-06T13:26:18Z

Thanks @peterM this works for me - although I only use a limited set of features here (basically I use this primarily to trigger a rebuid of a .tt template when an xml file is changed)

I do notice however that it can only be loaded via allowing synchronous packages to load. Is this something that is simple to update?

Also maybe @olegsych could accept and make this official?

peterM · 2020-06-01T11:17:30Z

Thanks @peterM this works for me - although I only use a limited set of features here (basically I use this primarily to trigger a rebuid of a .tt template when an xml file is changed)

I do notice however that it can only be loaded via allowing synchronous packages to load. Is this something that is simple to update?

Also maybe @olegsych could accept and make this official?

I tried to migrate it to use AsyncPackage what is new way how to integrate extensions into VS but it was not work and i do not have time to fix it.

alansingfield · 2020-06-07T09:18:01Z

I'm giving it a go based on PeterM's fork. The AsyncPackage is a bit of a bind. In a lot of places the ServiceLocator is passed down into the objects and stored. At a later point, in a synchronous method, it then tries to resolve a service.

Under the AsyncPackage you can't do this, because resolving services becomes an asynchronous process. (GetServiceAsync vs GetService)

So I'm refactoring the relevant objects to accept their dependencies through constructors. I'll do the service resolution asynchronously BEFORE object creation.

Once I've slain that dragon, I'll work out how to get the Visual Studio Integration tests working. MSTest v1 had some special sauce for running those which no longer exists in MSTest v2.

dbalciunas · 2020-09-11T03:25:23Z

I tried to compile the projects but I have the following problem:

First a compilation error:

            if (commandGroup == VSConstants.VSStd2K &&

VSConstants is not found and I find out that I have to install the package Microsoft.VisualStudio.Shell.Framework. But it seems one its dependencies is not compatible with .NET 4.72:

Install-Package : Could not install package 'Microsoft.ServiceHub.Analyzers 2.6.92'. You are trying to install this package into a
project that targets '.NETFramework,Version=v4.7.2', but the package does not contain any assembly references or content files that are compatible with that framework.

Rickrat · 2020-11-01T05:05:39Z

I was able to compile it and build the VSIX for Visual Studio 2019. Download it here: http://dl.compdj.us/download/index/T4Toolbox15003VS2019vsix

KarloX2 · 2020-11-15T07:57:14Z

Install-Package : Could not install package 'Microsoft.ServiceHub.Analyzers 2.6.92'. You are trying to install this package into a
project that targets '.NETFramework,Version=v4.7.2', but the package does not contain any assembly references or content files that are compatible with that framework.

@dbalciunas Have you been able to resolve /work around this issue or found the cause? I'm seing something similar when trying to update nuget packages of another vsix project.

Thanks!

dbalciunas · 2020-11-21T08:19:31Z

Install-Package : Could not install package 'Microsoft.ServiceHub.Analyzers 2.6.92'. You are trying to install this package into a
project that targets '.NETFramework,Version=v4.7.2', but the package does not contain any assembly references or content files that are compatible with that framework.

@dbalciunas Have you been able to resolve /work around this issue or found the cause? I'm seing something similar when trying to update nuget packages of another vsix project.

Thanks!

No, I don't. I didn't try anymore. Sorry.

KarloX2 · 2020-11-21T08:25:16Z

No, I don't. I didn't try anymore. Sorry.

Do you think one should open a separate issue on this? Where would be the right place for that?

bit7 · 2021-06-11T17:25:22Z

Why does this break with every release of Visual Studio? The T4Toolbox is such a great utility for what it does, this is really a pain.

Do we have a working build yet?

Migrate to support VS 2019

8f1ec74

peterM mentioned this pull request Apr 4, 2019

T4 Toolbox for VS 2019 #59

Open

Peter Malik added 9 commits April 4, 2019 08:33

Put back 'this'

6a6f228

Put back 'this'

23ef1a3

Put back 'this'

cdb5e11

Try fix tests

d9aff85

Fix 'CreateTaggerThrowsArgumentNullExceptionWhenBufferIsNullToFailFas…

786f1fb

…t' test

Remove unused fields in test

90a00c3

Try Fix 'TemplateQuickInfoSourceTest' test

f7f2ec9

Remove unused using

a828efb

Remove hint path from reference

0d1e897

tomblodget mentioned this pull request May 26, 2019

Support T4 Toolbox for VS 2019？？ #62

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for VS 2019 #60

Add support for VS 2019 #60

peterM commented Apr 4, 2019 •

edited

Loading

hippasus commented Apr 4, 2019

peterM commented Apr 4, 2019

3milio commented Apr 5, 2019

peterM commented Apr 6, 2019 •

edited

Loading

3milio commented Apr 12, 2019

peterM commented Apr 15, 2019

peterM commented Apr 23, 2019

ben1628 commented May 28, 2019

peterM commented May 28, 2019 •

edited

Loading

hbailles3 commented Jul 29, 2019 •

edited

Loading

imran517 commented Aug 15, 2019

SpartanDigitalDotNet commented Aug 15, 2019 •

edited

Loading

peterM commented Aug 21, 2019

peterM commented Aug 22, 2019 •

edited

Loading

niconico49 commented Sep 27, 2019

mika76 commented Oct 6, 2019

peterM commented Jun 1, 2020

alansingfield commented Jun 7, 2020

dbalciunas commented Sep 11, 2020

Rickrat commented Nov 1, 2020

KarloX2 commented Nov 15, 2020

dbalciunas commented Nov 21, 2020

KarloX2 commented Nov 21, 2020

bit7 commented Jun 11, 2021

Add support for VS 2019 #60

Are you sure you want to change the base?

Add support for VS 2019 #60

Conversation

peterM commented Apr 4, 2019 • edited Loading

hippasus commented Apr 4, 2019

peterM commented Apr 4, 2019

3milio commented Apr 5, 2019

peterM commented Apr 6, 2019 • edited Loading

3milio commented Apr 12, 2019

peterM commented Apr 15, 2019

peterM commented Apr 23, 2019

ben1628 commented May 28, 2019

peterM commented May 28, 2019 • edited Loading

hbailles3 commented Jul 29, 2019 • edited Loading

imran517 commented Aug 15, 2019

SpartanDigitalDotNet commented Aug 15, 2019 • edited Loading

peterM commented Aug 21, 2019

peterM commented Aug 22, 2019 • edited Loading

niconico49 commented Sep 27, 2019

mika76 commented Oct 6, 2019

peterM commented Jun 1, 2020

alansingfield commented Jun 7, 2020

dbalciunas commented Sep 11, 2020

Rickrat commented Nov 1, 2020

KarloX2 commented Nov 15, 2020

dbalciunas commented Nov 21, 2020

KarloX2 commented Nov 21, 2020

bit7 commented Jun 11, 2021

peterM commented Apr 4, 2019 •

edited

Loading

peterM commented Apr 6, 2019 •

edited

Loading

peterM commented May 28, 2019 •

edited

Loading

hbailles3 commented Jul 29, 2019 •

edited

Loading

SpartanDigitalDotNet commented Aug 15, 2019 •

edited

Loading

peterM commented Aug 22, 2019 •

edited

Loading