only send packets to the selected interface, not all interfaces #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the
ipv{4,6}connis bound to224.0.0.1:5353which works out to0.0.0.0:5353when you ask the connection'sLocalAddr()method. Accordingly, multicast writes go out to all interfaces of the host.I have a situation where I announce my services on two different network interfaces, each of which has its own IP address. As all packets are sent to all interfaces, one of the updates will win and it will not always be the right one.
In this pull request I added calls to
*ipv{4,6}.PacketConn.SetMulticastInterface. This makes the underlying*net.UDPConns send out multicast packets on only the specified interface, thereby correcting the behavior.Thanks for writing this library :)