Fixes and additions to make it work with dns-sd #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse (if requested)
Send multiple announcement messages in doubled intervals
Those methods returned the shutdown channel before, which was used for signaling a shutdown. On server shutdown multicast messages are sent for SRV and TXT records with TTL 0. From the outside you don't know how long this takes. It may happen that the app terminates before any message was successfully sent. Now Shutdown() is called manually which returns when all messages were sent. Add method to set and announce new text records
|
Thanks. The changes look good to me. I'm glad the library is getting better - it was a really quick roll out as we needed bonjour in our project ASAP. |
oleksandr
pushed a commit
that referenced
this pull request
Mar 2, 2015
Fixes and additions to make it work with dns-sd
wesen
added a commit
to wesen/bonjour
that referenced
this pull request
Nov 22, 2018
✨ Restructure bonjour server to take a chan of entries, allowing for live update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library with my changes pretty heavily and it works reliably enough that I would like to see my changes in the main repo.
Here is what changed and why.
Server
Fixes
server.go:315)Register()now returns aServerinstance because the server shutdown is done by callingShutdown()instead of using the shutdown channel.Problem with a shutdown channel arises when it's not clear how long the shutdown will take because the shutdown process runs in a separate goroutine. It may happen that the program terminates before the server was able to send goodbye packets. This can be prevented by calling
Shutdown().Additions
server.go:547)composeLookupAnswers()(server.go:411)SetText()update and reannounces TXT records_services._dns-sd._udp.<domain>dns query (server.go:343)Client