[yang][smartswitch] Add YANG model for MID_PLANE_BRIDGE and DPU tables. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
reviewed
Nov 18, 2023
| leaf dpu_name { | ||
| description "Name of the DPU"; | ||
| type string { | ||
| pattern "dpu[0-9]+"; |
There was a problem hiding this comment.
If dpu name = dpu interface why do we need this table?
There was a problem hiding this comment.
we will have more information in the table later. For example PCI ID, data plane interface mapping to the DPU interface, etc.
There was a problem hiding this comment.
Can we then add a check that midplane_interface = dpu_name? Since the interface names are created based on the DPU to which they are mapped, it is better to enforce this check
dgsudharsan
suggested changes
Nov 21, 2023
| leaf dpu_name { | ||
| description "Name of the DPU"; | ||
| type string { | ||
| pattern "dpu[0-9]+"; |
There was a problem hiding this comment.
Can we then add a check that midplane_interface = dpu_name? Since the interface names are created based on the DPU to which they are mapped, it is better to enforce this check
oleksandrivantsiv
force-pushed
the
smartswitch-yang
branch
from
9f199a3
to
d2eedf7
Compare
dgsudharsan
approved these changes
Nov 22, 2023
oleksandrivantsiv
pushed a commit
that referenced
this pull request
Jan 31, 2024
…tically (sonic-net#17847) #### Why I did it src/sonic-dash-api ``` * 8f481de - (HEAD -> master, origin/master, origin/HEAD) [misc]: Add utils CLI (#12) (24 hours ago) [Ze Gan] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add the YANG model according to TODO HDL.
Work item tracking
How I did it
Implement new YANG model containers.
How to verify it
Run YANG model unit tests. The changes add new unit tests to cover new functionality.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)