[Mellanox] Update mlnx-fw-upgrade.j2 to support BF3 DPU NIC FW. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrivantsiv
force-pushed
the
mlx-fw-upgrade
branch
2 times, most recently
from
e58bc4d
to
2240d51
Compare
Yakiv-Huryk
approved these changes
Aug 7, 2024
vivekrnv
reviewed
Aug 8, 2024
| @@ -339,7 +427,13 @@ function UpgradeFW() { | |||
| if [[ "${_FW_CURRENT}" == "${_FW_AVAILABLE}" ]]; then | |||
| ExitSuccess "firmware is up to date" | |||
| else | |||
| if [[ "${DRY_RUN}" == "${YES_PARAM}" ]]; then | |||
There was a problem hiding this comment.
Why do we need this? Just for user convenience?
There was a problem hiding this comment.
Got it, used it in bfnet.sh. I think "upgrade_check" or similar name would be better than dry_run
There was a problem hiding this comment.
I don't agree with this. --dry-run is widely used by Linux commands for purposes like this.
nazariig
suggested changes
Aug 28, 2024
platform/mellanox/mlnx-fw-upgrade.j2
Outdated
|
|
||
| RunCmd "${LIST_CONTENT_CMD} -i ${_FW_FILE} -d ${_MST_DEVICE} -o ${LIST_CONTENT_FILE}" | ||
|
|
||
| ERROR_CODE="$?" |
There was a problem hiding this comment.
@oleksandrivantsiv why do we need it? RunCmd exits script if rc != 0
There was a problem hiding this comment.
removed, thanks
oleksandrivantsiv
force-pushed
the
mlx-fw-upgrade
branch
from
2240d51
to
87ea9cc
Compare
nazariig
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Extend
mlnx-fw-upgrade.j2to support the upgrade of the DPU NIC FWWork item tracking
How I did it
Add support for the new device to the script
How to verify it
Compile and install an image
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)