Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceMember is not entirely correct. #51

Closed
matklad opened this issue Sep 2, 2018 · 0 comments · Fixed by #59
Closed

WorkspaceMember is not entirely correct. #51

matklad opened this issue Sep 2, 2018 · 0 comments · Fixed by #59

Comments

@matklad
Copy link
Contributor

matklad commented Sep 2, 2018

In cargo's output, package id is opaque identifier. The proper way to extract package's name, version and stuff is to look it in the packages array by the id and inspect the fields. WorkspaceMember instead splits the id. This works at the moment, but this is not guaranteed to work.

epage added a commit to epage/escargot that referenced this issue Dec 31, 2018
@matklad matklad mentioned this issue Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant