implement Eq for Package

[MarcoIeni]

No description provided.

[jyn514]

When would this be useful?

[MarcoIeni]

In https://github.com/MarcoIeni/release-plz I wanted to compare a package that I have edited locally with the same downloaded from crates.io.

[oli-obk]

Are you interested in plain equality or will you need a diff anyway? In the latter case I would recommend serializing to json and using a json diff crate or tool

[MarcoIeni]

For my use case I was just interested in equality. Anyway, apart from my use case, I submitted the PR because it's also suggested in the API guidelines.
Do you see any cons in implementing equality?

[oli-obk]

Well... it's a huge type that seemed not useful for such traits to me. There's always some cost to adding such impls, but it's not relevant if there's a use case.

So i'll merge this, just gotta figure out the CI failure first

[ehuss]

Sorry about the tests, I have opened #173 with the fixes.

[oli-obk]

published as 0.14.2