Skip to content

Rustup #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2019
Merged

Rustup #12

merged 3 commits into from
Jan 21, 2019

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Oct 19, 2018

Will update when rust-lang/rust#55179 has landed.

I switched to the 2018 edition for try blocks.

@bjorn3 bjorn3 requested a review from oli-obk October 19, 2018 12:55
Some(ecx.eval_operand(&mir::Operand::Move(mir::Place::Local(id)), None).unwrap())

} else {
None // TODO Above doesn't work for non top frames
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@@ -182,6 +183,8 @@ pub fn render_main_window(
)
}

// TODO Memory::allocations doesn't exist anymore
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remainder to self

Copy link
Owner

@oli-obk oli-obk Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. yea, that should be trivial to reintroduce. Do you want to add it to your rustc PR? (Again, with a comment that priroda needs this)

alternatively (or just do it) you can do something super evil:

Implement AllocMap for a new ZST type that you create. Forward every method to a FxHashMap that you created in a lazy static. Now you have full access to the underlying memory by accessing the lazy static ;)

Ok, don't do that. A simple getter function should be ok to have in rustc. Remember to add a comment about priroda

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to my rustc PR

@bjorn3 bjorn3 mentioned this pull request Nov 27, 2018
@oli-obk
Copy link
Owner

oli-obk commented Jan 21, 2019

I'll merge and keep working on top of it

@oli-obk oli-obk merged commit 90f8531 into oli-obk:master Jan 21, 2019
@bjorn3 bjorn3 deleted the rustup branch January 21, 2019 17:25
@bjorn3
Copy link
Collaborator Author

bjorn3 commented Jan 21, 2019

I forgot about this PR :(

@oli-obk
Copy link
Owner

oli-obk commented Jan 22, 2019

The master branch is back in business. Not everything works though (you commented out a few things that I didn't look at yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants