-
Notifications
You must be signed in to change notification settings - Fork 12
Rustup #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustup #12
Conversation
Some(ecx.eval_operand(&mir::Operand::Move(mir::Place::Local(id)), None).unwrap()) | ||
|
||
} else { | ||
None // TODO Above doesn't work for non top frames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
@@ -182,6 +183,8 @@ pub fn render_main_window( | |||
) | |||
} | |||
|
|||
// TODO Memory::allocations doesn't exist anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remainder to self
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. yea, that should be trivial to reintroduce. Do you want to add it to your rustc PR? (Again, with a comment that priroda needs this)
alternatively (or just do it) you can do something super evil:
Implement AllocMap
for a new ZST type that you create. Forward every method to a FxHashMap
that you created in a lazy static. Now you have full access to the underlying memory by accessing the lazy static ;)
Ok, don't do that. A simple getter function should be ok to have in rustc. Remember to add a comment about priroda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to my rustc PR
I'll merge and keep working on top of it |
I forgot about this PR :( |
The master branch is back in business. Not everything works though (you commented out a few things that I didn't look at yet) |
Will update when rust-lang/rust#55179 has landed.
I switched to the 2018 edition for
try
blocks.