Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, no summary is printed at the end #238

Closed
RalfJung opened this issue Jun 12, 2024 · 2 comments · Fixed by #242 or #246
Closed

Sometimes, no summary is printed at the end #238

RalfJung opened this issue Jun 12, 2024 · 2 comments · Fixed by #242 or #246

Comments

@RalfJung
Copy link
Collaborator

Running ./test.sh in MiniRust sometimes looks like this:

[...]
tests/pass/static.fixed ⠒ 
tests/pass/zst.fixed ⠒ 
tests/pass/const.fixed ⠒ 
tests/pass/enum_direct_tag.fixed ⠒ 
tests/pass/tuples.fixed ⠒ 
tests/pass/union.fixed ⠚ 
tests/pass/enum_niche_tag.fixed ⠚ 
tests/ub/inv_bool.fixed ⠚ 
tests/ub/unaligned.fixed ⠚ 
tests/ub/return_ref_to_local.fixed ⠚ 
tests/ub/array_out_of_bounds.fixed ⠚ 
tests/ub/nullptr.fixed ⠚ 
tests/ub/destroy_prov.fixed ⠚ 
tests/pass/is_zero.fixed ⠚ 
tests/ub/enum_mark_used_bytes.fixed ⠚     r@r-ethtop:~/src/rust/minirust (master=)$ 

Somehow, properly marking all tests as finished and printing the summary with the number of passed tests is skipped. This is non-deterministic, so likely a race condition.

I have not seen this happen before minirust/minirust#188 landed.

@oli-obk
Copy link
Owner

oli-obk commented Jun 12, 2024

Yea looks like if rendering takes too long, we may exit before finishing rendering

@RalfJung
Copy link
Collaborator Author

Possibly related, I am also often getting this when a test fails:

Error: tests failed

Location:
    /home/r/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ui_test-0.23.0/src/lib.rs:310:13
error: test failed, to rerun pass `--test ui`

No details of the actual failure is printed. Needless to say, that makes debugging kind of tricky ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants