Nextest #161
Merged
Nextest #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In clippy when we see if env::args().any(|arg| arg == "--list") {
if !env::args().any(|arg| arg == "--ignored") {
println!("compile_test: test");
}
return;
}With the actual list of tests it will execute it once per test (at some level of parallelism) which would be slower when it already implements internal concurrency and can reuse aux builds between tests. Seems like concurrent compilation of the same aux file has some problems too |
Alexendoo
reviewed
Sep 6, 2023
Comment on lines
+247
to
+249
| if config.filter_exact | ||
| && config.filter_files.len() == 1 | ||
| && config.filter_files[0] == "ui_test" |
There was a problem hiding this comment.
If TESTNAME is used there could be some other filters in here since args extends the config's list
There was a problem hiding this comment.
I guess... filtering out just one specific name seems not great tho
There was a problem hiding this comment.
Yeah I wouldn't be too fussed if you ignored that
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 6, 2023
Fix `i686-unknown-linux-gnu` CI job When testing oli-obk/ui_test#161 I gave `--ignored` a try, I was surprised to see many of the 32bit tests passing even though I'm on a 64bit target Turns out the `.stderr`s were incorrect, and our `i686-unknown-linux-gnu` job has been running `x86_64-unknown-linux-gnu` so it didn't get picked up changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 23, 2024
Fix running compile-test under cargo nextest `ui_test` itself has `cargo nextest` support which we now use - oli-obk/ui_test#161 It prints `ui_test` as its test name whereas we printed `compile_test`, this ended up being treated as a test name filter causing all the tests to be filtered out changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #158
cc @Alexendoo