Move the bless command to a field in Config #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage in clippy showed that #157 made the API a bit awkward with regards to the bless command and conflict handling modes, this takes it from
to
The default conflict handling is now only specified in the
Config
, no morebool
inwith_args
It's a separate (optional) field because in order for
OutputConflictHandling::Bless
+--check
to work it had to supply a bless command of its own, but there's not really a sensible default suggestion we can make