Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $DIR replacement of test's parent directory #180

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

Alexendoo
Copy link
Contributor

I've often wanted to ditch the $DIR replacement to make paths clickable in the terminal, this would allow that

@oli-obk
Copy link
Owner

oli-obk commented Oct 12, 2023

Will that work in clippy and miri CI? If so, should we just ditch it in general?

@Alexendoo
Copy link
Contributor Author

Yeah it should:tm: work fine as it's replacing a relative path. The biggest thing is it will be a hefty diff when upgrading ui_test

Ditching it in general sounds good to me, it could be recreated without a new Match by using the per test config callback if it's desired somewhere

@Alexendoo Alexendoo changed the title Make test parent dir replacement configurable Remove $DIR replacement of test's parent directory Oct 13, 2023
@Alexendoo
Copy link
Contributor Author

Also removed the RUSTLIB replacement as neither clippy or MIRI use it (tested in the rust repo as well)

@oli-obk oli-obk merged commit 65625e1 into oli-obk:main Oct 13, 2023
5 checks passed
@Alexendoo Alexendoo deleted the parent-dir branch October 13, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants