Add option to set minimum "mandatory" message level #182
Conversation
|
Why doesn't |
|
It would need to be added to all clippy tests with mixed levels. It's a possibility, but I found it easier to set it directly for all tests (since it's already possible to use this option...) rather than adding it in hundred of existing ones. It will also makes things simpler for potential future new tests with mixed annotation levels if users don't need to know about this annotation (which, I precise, does exactly what we need). |
|
While there are hundreds of test files with them in currently, almost all of them contain only We could bring it up at a meeting, but my impression is we will remove all the |
|
If it's only this kind of note messages, then better remove them indeed. Just would be sad to prevent adding other annotations but if it's what clippy devs want, fine by me. :) |
|
The way we should implement something like this in ui_test is to provide a default test config. That's a major refactoring that I probably have lots of opinions on, so I'd like to not just review impls but be part of the design and brain storm phase. |
|
We're not in a hurry so more discussions and brain storming are very welcome. |
|
This is resolved by #183 |
It is needed for clippy because we only want to set "error" message annotations as mandatory and not fail in case lower level are present in the file.
The reason is that currently, if a lower level message annotation is present, the "general level" of annotation becomes the lowest present in the test file, which is not something we want.
Needed for rust-lang/rust-clippy#11421.