Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff-only output on Text #236

Merged
merged 2 commits into from
May 28, 2024
Merged

Add diff-only output on Text #236

merged 2 commits into from
May 28, 2024

Conversation

xldenis
Copy link

@xldenis xldenis commented May 28, 2024

This solves #229, I generalized the progress boolean to instead store the desired verbosity and added a method to construct a diff status emitter which just returns an empty drop guard rather than the full text.

The todo list below is accurate: I still need to add tests.

TODO

  • Add tests
  • Add CHANGELOG.md entry

oli-obk
oli-obk previously approved these changes May 28, 2024
@xldenis
Copy link
Author

xldenis commented May 28, 2024

Ok I've added a test showing that I actually suppress the full output.

@oli-obk
Copy link
Owner

oli-obk commented May 28, 2024

Great! Thanks!

@oli-obk oli-obk merged commit 10ff09d into oli-obk:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants