Adds compatibility with Renpho (QN Scale) scales that use the 2nd set of characteristics #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDharmasiri
commented
Nov 6, 2024
EDharmasiri
commented
- I'm not able to test how this affects anyone with the older/currently working scales
… of characteristics
|
Regarding Renpho ES-CS20M: The app doesn´t crash anymore, but the measurements seem to randomly use the different types. Sometimes the real values are used, sometimes wrong values and the weight/10 |
|
Thanks for your PR @EDharmasiri @ndurchx do you mean by wrong values that the weight is sometimes divided by 10? Could you explain it more in detail when what happen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.