Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix selectRange and clipboard bug #4415

Merged

Conversation

lstgithub578
Copy link
Contributor

Please deal with this bug#4414 before dealing with it. Demo cannot be provided because bug#4414 exists.

Bug description

this.table = new TabulatorFull("#container", {
			groupBy: "group",
			layout: "fitColumns",
			selectableRange: 1,
			selectableRangeColumns: false,
			selectableRangeRows: false,
			selectableRangeClearCells: true,
			editTriggerEvent: "dblclick",
			clipboard: true,
			clipboardCopyStyled: false,
			clipboardCopyConfig: {
				columnHeaders: false,
			},
			clipboardCopyRowRange: "range",
			clipboardPasteParser: "range",
			clipboardPasteAction: "range",
			columnDefaults: {
				headerSort: false,
				editor: "input",
				editable: true,
			},
			data: [
				{
					group: "GroupFoo",
					A: "A1",
					B: "B1",
					row: 1,
				},
				{
					group: "GroupFoo",
					A: "A2",
					B: "B2",
					row: 2,
				},
				{
					group: "GroupFoo",
					row: 3,
				},
				{
					group: "GroupFoo",
					row: 4,
				},
			],
			columns: [
				{
					field: "row",
					width: 10,
				},
				{
					title: "A",
					field: "A",
				},
				{
					title: "B",
					field: "B",
				},
			],
		});

When we use "selectableRange" and "clipboard", the following problems will occur.
image

  • As shown in the figure,When we copy the value of A2 to A3, we will actually change the value of A2 into the value of A1.
  • When "A4" is selected, and then the keys of "shift" and "down" are pressed, it is out of the range of the array and an error is reported.
    image

The above two bugs are caused by "groupComponent" not being filtered.

@olifolkerd olifolkerd changed the base branch from master to 6.0 March 11, 2024 13:52
@olifolkerd olifolkerd merged commit 96de27c into olifolkerd:6.0 Mar 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants