fix: SASS deprecation warning on tabulator themes #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing some of my apps that uses tabulator, these warnings started showing up:
This PR will fix these deprecation warnings by moving the border stylings from below the
.tabulator-rowclass to above it. I'm assuming this will not impact anything as the styles being changed inside.tabulator-rowis not manipulating border stylings. However, if there's a reason why it was placed below, then let me know and I can modify it so that we can follow this style declaration suggested by the SASS documentation:Here's some more info on this SASS breaking change: https://sass-lang.com/documentation/breaking-changes/mixed-decls/