Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore flag #42

Closed
wants to merge 3 commits into from
Closed

add ignore flag #42

wants to merge 3 commits into from

Conversation

wings132
Copy link

i'd like to add an ignore flag. If some modules' new version has bug, i want to ignore it.

@oligot
Copy link
Owner

oligot commented Sep 30, 2023

Nice suggestion !

2 small improvements:

  • we should filter the list of modules in the discover function, so that when the ignore flag is given, the ignored modules are already taken into account in this function
  • to log the ignored modules, you could use the apex/log module instead of the "fmt" module, so that it's coherent with the rest of the code

@wings132
Copy link
Author

wings132 commented Oct 1, 2023

@oligot Hi,adding ignore in discover function is a better way ! So i change the code as you said. Please review it when you are free. Thanks !

@oligot oligot closed this in 9d228cd Oct 9, 2023
@oligot
Copy link
Owner

oligot commented Oct 9, 2023

Hi,

I've reviewed and merged your PR.
I've used a StringSlice instead of a string to store the ignore modules from the cli.

This can be used as follow

go-mod-upgrade --ignore color --ignore cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants