Diff from branch-point-with-tests to 0-18-x #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oligriffiths
changed the base branch from
branch-point
to
branch-point-with-tests
oligriffiths
changed the title
oligriffiths
changed the title
This was referenced Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common root of 0-18-x and master is
ab404ef725be5c265c901838be40d0358a867ec4The commit just after that is
f5a1f3ddb1a01a4a9c312be12f1efed2b6d38611(branch-point-with-tests) which converts the test suite from tap to mocha.This diff is from
f5a1f3ddb1a01a4a9c312be12f1efed2b6d38611to 0-18-x, as we have since converted the test suite to mocha, so rather than include those changes in the diff, I'm branching off after the mocha changes were made.This also includes only changes, no deletions to keep the diff down, as most of the
libfolder was removed in the 0-18-x series, but not in the actual broccoli master.