Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCIO improvements #1880

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

OCIO improvements #1880

wants to merge 18 commits into from

Conversation

ThomasWilshaw
Copy link
Collaborator

@ThomasWilshaw ThomasWilshaw commented Mar 14, 2022 •
edited
Loading

A WIP set of colour related improvments:

  • Update the OCIO config to use families and take advantage of file rules
  • Implement custom comboboxes for colour space picking and use OCIO MenuHelpers to filter/organise them
  • Replace existing colour space drop downs with new combo box
  • Improve config validation on load
  • Add a default_float and default_byte type
  • Implement semi auto colour space selection for input using file roles and buffer format
  • Re add the display space input tab for colour picking
  • Add a check for the cie interchange space

Any other ideas are welcome

@ThomasWilshaw
Use MenuHelper to clean up input menu
83f58e2
@ThomasWilshaw
Improve config validation
d65470f
@ThomasWilshaw
Improve menu helper usage
d3becaa
@ThomasWilshaw
Use file rules to try and set the correct color space
06ccfbc
@ThomasWilshaw
Improve comments
fb5451f
@ThomasWilshaw
config.ocio: Update family
f809009
@ThomasWilshaw
Implement ColorSpaceComboBox
02c4d3b 
This is an extended version of QComboBox with a built in MenuHelper
from OCIOv2. These menus are filtered based on config categories and
sub menus are created by config familes.
@ThomasWilshaw
Add default float and byte color spaces
3d71382 
These replace the previous default color space. If an OCIO config has
the roles default_byte and default_float we use them. Otherwise we fall
back onto OCIO::ROLE_DEAFULT.
@ThomasWilshaw
Add FIXME
d31e5cf
@ThomasWilshaw
colorspacechooser: Use colorspacecombobox for Input
8de5d06
@ThomasWilshaw
Re add display input for the color picker
25181c4
@ThomasWilshaw
Copy link
Collaborator Author

@itsmattkc sorry I've dropped this fo rso long. I've updated it to master and wondered if you could have a quick look. Probably needs some clean up but I'll mark it as not a draft. Exmaple of the colour space combobox below:
image

@ThomasWilshaw ThomasWilshaw marked this pull request as ready for review October 8, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmattkc itsmattkc Awaiting requested review from itsmattkc

@sobotka sobotka Awaiting requested review from sobotka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ThomasWilshaw