Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to test the PEP 517 ability #1

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Try to test the PEP 517 ability #1

merged 2 commits into from
Sep 27, 2021

Conversation

MetRonnie
Copy link

No description provided.

@oliver-sanders
Copy link
Owner

Test is failing because the setup.py variant is patching the version with the ! epoch, but the setup.cfg one isn't.

@oliver-sanders
Copy link
Owner

(for isodatetime/rose we can have __version__ & __version_with_epoch__ attributes or something like that)

@oliver-sanders oliver-sanders mentioned this pull request Sep 27, 2021
Merged
oliver-sanders
oliver-sanders approved these changes Sep 27, 2021
View reviewed changes
Copy link
Owner

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@oliver-sanders oliver-sanders merged commit 69deb68 into oliver-sanders:pep517 Sep 27, 2021
@MetRonnie MetRonnie deleted the pr/oliver-sanders/24 branch September 27, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MetRonnie @oliver-sanders