feat: add label master_replid to metricinstance_info (#924)

oliver006 · Aug 9, 2024 · 55476aa · 55476aa
1 parent 5aeb972
commit 55476aa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/exporter/exporter.go b/exporter/exporter.go
@@ -365,7 +365,7 @@ func NewRedisExporter(redisURI string, opts Options) (*Exporter, error) {
 		"db_keys_cached":                                  {txt: "Total number of cached keys by DB", lbls: []string{"db"}},
 		"errors_total":                                    {txt: `Total number of errors per error type`, lbls: []string{"err"}},
 		"exporter_last_scrape_error":                      {txt: "The last scrape error status.", lbls: []string{"err"}},
-		"instance_info":                                   {txt: "Information about the Redis instance", lbls: []string{"role", "redis_version", "redis_build_id", "redis_mode", "os", "maxmemory_policy", "tcp_port", "run_id", "process_id"}},
+		"instance_info":                                   {txt: "Information about the Redis instance", lbls: []string{"role", "redis_version", "redis_build_id", "redis_mode", "os", "maxmemory_policy", "tcp_port", "run_id", "process_id", "master_replid"}},
 		"key_group_count":                                 {txt: `Count of keys in key group`, lbls: []string{"db", "key_group"}},
 		"key_group_memory_usage_bytes":                    {txt: `Total memory usage of key group in bytes`, lbls: []string{"db", "key_group"}},
 		"key_size":                                        {txt: `The length or size of "key"`, lbls: []string{"db", "key"}},

diff --git a/exporter/info.go b/exporter/info.go
@@ -168,7 +168,10 @@ func (e *Exporter) extractInfoMetrics(ch chan<- prometheus.Metric, info string,
 		keyValues["redis_mode"],
 		keyValues["os"],
 		keyValues["maxmemory_policy"],
-		keyValues["tcp_port"], keyValues["run_id"], keyValues["process_id"],
+		keyValues["tcp_port"],
+		keyValues["run_id"],
+		keyValues["process_id"],
+		keyValues["master_replid"],
 	)
 
 	if keyValues["role"] == "slave" {