-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keydb multimaster support #710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good but a couple of smaller issues:
-
There are a couple of comments in the linter that make sense (see here: https://cloud.drone.io/oliver006/redis_exporter/1709/1/15)
-
Can you also please run "go fmt" on your change to make sure it's properly formatted?
- precompile all regexp - run go fmt
Pull Request Test Coverage Report for Build 1724
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 88.24% 88.26% +0.02%
==========================================
Files 16 16
Lines 1956 1960 +4
==========================================
+ Hits 1726 1730 +4
Misses 154 154
Partials 76 76
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes. Two minor issues and then this should be good to go!
Add support for info keys like master_[0-9]_ which are produced by keydb in case there are more than 1 master.