Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keydb multimaster support #710

Merged
merged 3 commits into from
Oct 28, 2022
Merged

keydb multimaster support #710

merged 3 commits into from
Oct 28, 2022

Conversation

mihaiush
Copy link
Contributor

Add support for info keys like master_[0-9]_ which are produced by keydb in case there are more than 1 master.

redis_master_link_up{master_host="m0.server.local",master_port="6377"} 1
redis_master_link_up{master_host="m1.server.local",master_port="6377"} 1

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good but a couple of smaller issues:

- precompile all regexp
- run go fmt
@coveralls
Copy link

coveralls commented Oct 26, 2022

Pull Request Test Coverage Report for Build 1724

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.167%

Totals Coverage Status
Change from base Build 1700: 0.02%
Covered Lines: 1812
Relevant Lines: 1966

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #710 (340aeec) into master (8deeeaf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   88.24%   88.26%   +0.02%     
==========================================
  Files          16       16              
  Lines        1956     1960       +4     
==========================================
+ Hits         1726     1730       +4     
  Misses        154      154              
  Partials       76       76              
Impacted Files Coverage Δ
exporter/info.go 95.93% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes. Two minor issues and then this should be good to go!

exporter/info.go Outdated Show resolved Hide resolved
exporter/info.go Outdated Show resolved Hide resolved
@oliver006 oliver006 merged commit ec7ec0f into oliver006:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants