Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redis sentinel master config #857

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Conversation

opan
Copy link
Contributor

@opan opan commented Dec 12, 2023

Expose couple new metrics to show current redis sentinel master config, such as quorum, parallel-syncs, failover-timeou, and down-after-milliseconds. As of now, I have only expose these 4 settings. We can add more if needed.

Thank you

@coveralls
Copy link

Pull Request Test Coverage Report for Build 224

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.203%

Totals Coverage Status
Change from base Build 221: 0.2%
Covered Lines: 1963
Relevant Lines: 2129

💛 - Coveralls

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks for the PR!

Is it worth adding a few tests for this to check the metrics show up?

@opan
Copy link
Contributor Author

opan commented Dec 13, 2023

Sure, I can add some test for this.

@oliver006 oliver006 merged commit a9d587f into oliver006:master Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants