Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add collection of mem_total_replication_buffers metric introduced in Redis 7.0 #910

Merged
merged 1 commit into from
May 24, 2024
Merged

Feature: Add collection of mem_total_replication_buffers metric introduced in Redis 7.0 #910

merged 1 commit into from
May 24, 2024

Conversation

nantiferov
Copy link
Contributor

@nantiferov nantiferov commented May 24, 2024 •
edited
Loading

Hope I haven't missed anything to add.

Fixes: #909

@coveralls
Copy link

Pull Request Test Coverage Report for Build 349

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 84.238%
Totals Coverage Status
Change from base Build 344: 0.007%
Covered Lines: 1972
Relevant Lines: 2341
💛 - Coveralls

oliver006
oliver006 approved these changes May 24, 2024
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@oliver006 oliver006 merged commit 19da3bb into oliver006:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver006 oliver006 oliver006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for mem_total_replication_buffers redis 7.0 metric
3 participants
@nantiferov @coveralls @oliver006