Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix search_total_indexing_time metric type #958

Conversation

nantiferov
Copy link
Contributor

@nantiferov nantiferov commented Oct 8, 2024

According to my tests with real workload, this metric type is counter, I'm renaming it according to Prometheus recommendations and moving to metricMapCounters map.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (c59f5c4) to head (b3738c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          18       18           
  Lines        2204     2204           
=======================================
  Hits         1806     1806           
  Misses        311      311           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11233460310

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.368%

Totals Coverage Status
Change from base Build 11228266063: 0.006%
Covered Lines: 2252
Relevant Lines: 2638

💛 - Coveralls

According to my tests this metric type is counter, I'm renaming it according to Prometheus recommendations and moving to `metricMapCounters` map.
@nantiferov nantiferov force-pushed the Hotfix--Fix-search_total_indexing_time-metric-type branch from 679fda6 to b3738c1 Compare October 8, 2024 10:22
@nantiferov nantiferov marked this pull request as ready for review October 8, 2024 10:23
@nantiferov
Copy link
Contributor Author

Not urgent, so far we just have warnings from Grafana that metric name doesn't end with _total

image

@oliver006
Copy link
Owner

Thanks for the quick fix!

@oliver006 oliver006 merged commit 6d86815 into oliver006:master Oct 8, 2024
10 checks passed
@oliver006
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants