Fix bug when indexing a document with empty fields #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was causing issues when adding a document with an empty field, 0 / 0 would give a NaN which would end up as the tf, and then as the documents score against a query
olivernn
added a commit
that referenced
this pull request
May 17, 2013
Fix bug when indexing a document with empty fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to #28 which fixes #27.
This makes sure that documents with an empty field do not end up getting a
NaNscore when searching.If a field has no tokens it should not contribute to the tf for that token, before it was and 0 / 0 leads to a
NaN.